Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a white list of projects allowed to create benchmark jobs #43

Open
tallysmartins opened this issue Aug 7, 2018 · 4 comments
Open

Comments

@tallysmartins
Copy link
Member

tallysmartins commented Aug 7, 2018

As our runners are limited resources, we could have a white list of projects allowed to have their benchmarks running. This projects could be exported and read to a file or environment variables. By now we would have only Ecto.

@PragTob
Copy link
Member

PragTob commented Aug 8, 2018

As I said before - I'd only start doing this if this indeed becomes a problem :) And before that I beg more people for resources at elixirforum :D

Wdyt @michalmuskala ?

@michalmuskala
Copy link
Contributor

I think there are actually two factors we should take into consideration here:

  • server resources for running the benchmarks
  • security

I'm actually less worried about the former. It's true we're running the benchmarks in docker, but docker was not designed as a security sandbox, it's not perfect and there are ways (removed with each release) to escape to the host system.

Because of that, I think, for now we should run with a whitelist of projects.

@tallysmartins
Copy link
Member Author

tallysmartins commented Aug 9, 2018

and we already have the whitelist check... jobs are just created if the repository was added - manually - to the database.

@PragTob
Copy link
Member

PragTob commented Aug 10, 2018

The security concern I think we can never really get rid off. Unless I'm missing something that's also sort of what all CI hosts etc. have to live with? :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants