Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify cross-compiler for Adbc #19

Open
cocoa-xu opened this issue Jul 14, 2023 · 6 comments
Open

Specify cross-compiler for Adbc #19

cocoa-xu opened this issue Jul 14, 2023 · 6 comments
Assignees

Comments

@cocoa-xu
Copy link
Member

Right now Adbc would always use /usr/bin/x86_64-linux-gnu-gcc as the compiler. I'll try it and see how do I specify cross-compiler for Adbc. We should be able to do that by specifying CMAKE_TOOLCHAIN_FILE.

@cocoa-xu cocoa-xu self-assigned this Jul 14, 2023
@cocoa-xu
Copy link
Member Author

Actually, there is no need to build for other Linux targets than x86_64 because we're downloading official drivers which only have support for x86_64 Linux.

@lidavidm
Copy link

Where are the drivers being downloaded from? They should build on Linux (x64/ARM), macOS (x64/ARM), and Windows (x64). We only provide binaries via conda-forge, and those packages don't yet build for Windows there (someone needs to figure out the CI issues).

@cocoa-xu
Copy link
Member Author

Where are the drivers being downloaded from? They should build on Linux (x64/ARM), macOS (x64/ARM), and Windows (x64). We only provide binaries via conda-forge, and those packages don't yet build for Windows there (someone needs to figure out the CI issues).

We currently download drivers from the release page, for example, https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.11.0. These drivers are extracted from Python wheels.

@lidavidm
Copy link

ah, good to know, thanks. Uh, I suppose that isn't the intended use, but if it works...

@cocoa-xu
Copy link
Member Author

cocoa-xu commented Apr 12, 2024

ah, good to know, thanks. Uh, I suppose that isn't the intended use, but if it works...

Oh we were compiling these drivers at some point (hence the cc_toolchains directory in the repo), but I forgot if it was because it took too much time on CI or for other reasons, we decided to just use these drivers from Python wheels...

@josevalim
Copy link
Member

@lidavidm it would be nice if we could have only the drivers (outside of the wheels) but due to ADBC's design, they just work, yeah, so at least for now we don't see a reason to. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants