Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when specifying username with incompatible with the latest Minecraft versions #37

Open
erickskrauch opened this issue Dec 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@erickskrauch
Copy link
Member

@Nik-mmzd's report:

Майновый никнейм должен подходить под это условие, иначе юзеры со всякими там никами с кириллицей получают ошибки
Не обязательно запрещать, можно просто предупреждать, что подобный ник может не работать на всех версиях

Implementation from the decompiled Authlib to verify username:
Authlib's implementation of username validation

So it seems we need to introduce a warning on the profile and username change pages when a user enters any character, which will not pass the validation above. On the profile page, it should look the same as the warning about the already taken Mojang's username.

@erickskrauch erickskrauch added the enhancement New feature or request label Dec 12, 2022
@Nik-mmzd
Copy link

image
Also, 16 letters is maximum length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants