Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build production dist files with bootstrap-for-ember #168

Open
gordonbaz opened this issue Aug 22, 2014 · 9 comments
Open

Can't build production dist files with bootstrap-for-ember #168

gordonbaz opened this issue Aug 22, 2014 · 9 comments

Comments

@gordonbaz
Copy link

Hi there,
I've just had a problem with building production dist files and after lots of debugging (many, many thanks to Jamie White) we tracked down the problem to this ember-cli addon. After removing it and manually adding bootstrap the problem was resolved. See ember-cli/ember-cli#1727 for more detail

Thanks,
Gordon

@jgwhite
Copy link

jgwhite commented Aug 22, 2014

@gordonbaz it’s actually this addon that you had installed: https://github.com/dockyard/ember-cli-bootstrap

@tomish
Copy link

tomish commented Sep 27, 2014

I am having the same problem, but don't have the ember-cli addon installed. Just importing "ember-addons.bs_for_ember": "~0.7.0" in my bower.json

My project runs fine locally, but when i compile for production I am getting errors.

@piotrpalek
Copy link

@gordonbaz how did you manually use the bootstrap addon? I am having the same problem.

@gordonbaz
Copy link
Author

I changed my brocfile.js to read as follows:

app.import('bower_components/bootstrap/dist/js/bootstrap.js');
app.import('bower_components/bootstrap/dist/css/bootstrap.css');
var mergeTrees = require('broccoli-merge-trees');
var pickFiles = require('broccoli-static-compiler');
var extraAssets = pickFiles('bower_components/bootstrap/dist/fonts',{
srcDir: '/',
files: ['*/'],
destDir: '/fonts'
});

module.exports = mergeTrees([app.toTree(), extraAssets]);
// module.exports = app.toTree();

@theinventor
Copy link

@gordonbaz was that a fix/workaround, or is this still broken? Having same issue..

@gordonbaz
Copy link
Author

I must admit that I haven't tried out ember-cli-bootstrap since putting this fix in place - it's still working for me now though

@theinventor
Copy link

just looking at that code, it seems to be pulling in bootstrap - but not the other fun stuff in ember-cli-bootstrap. If you are using their modal shortcuts, and the notification stuff, I don't think that will work.. I'll keep trying :)

@theinventor
Copy link

OH - I did get passed my issue though - it had to do with the ordering in package.json,
"devDependencies":

now I have NEW issues!

@GottZ
Copy link

GottZ commented Oct 15, 2014

i noticed a relation to this issue: ember-cli/ember-cli#972
where this would result in an error if you run your production code:

template: Ember.Handlebars.compile(['{{#if view.content.template}}', '{{bsItemPanePartial view.content.template}}', '{{/if}}'].join("\n")),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants