Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing ESC key or clicking close (x) button in header closes modal without triggering cancel event #190

Open
descanso opened this issue Nov 29, 2014 · 0 comments

Comments

@descanso
Copy link

Pressing the escape key while the modal is visible will dismiss the modal without triggering the action associated with the button handling dismiss: 'modal'. That same is true for clicking the close button x in the modal header.

For example, when a cancel button is created in the controller using Ember.Object.create({title: 'Cancel', clicked:"cancel", dismiss: 'modal'}) clicking the button will trigger the cancel action and dismiss the modal. However, pressing the escape key or clicking the close button x in the modal header will only dismiss the modal without triggering the cancel action.

The examples in the Modal Showcase exhibit the behavior described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant