Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan v13 Release #2060

Open
bmish opened this issue Jan 13, 2024 · 6 comments
Open

Plan v13 Release #2060

bmish opened this issue Jan 13, 2024 · 6 comments
Labels

Comments

@bmish
Copy link
Member

bmish commented Jan 13, 2024

Breaking changes:

Previous release:

@bmish bmish added the breaking label Jan 13, 2024
@bmish bmish pinned this issue Jan 13, 2024
@Techn1x
Copy link

Techn1x commented Apr 22, 2024

We'll need eslint v9 support too. Currently I get this error

TypeError: context.getAncestors is not a function
from this line

context.getAncestors() is replaced in v9
https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context.getancestors()

That's just the one I found, there is potentially other things that need to change for eslint v9

@bmish
Copy link
Member Author

bmish commented Apr 22, 2024

Can you file a separate issue for that? ESLint v9 support can be fixed in a bug fix release.

@Techn1x
Copy link

Techn1x commented Apr 22, 2024

Can do, wasn't sure.

Will jump on that first thing tomorrow

@Techn1x
Copy link

Techn1x commented Apr 24, 2024

#2136

@LucasHill
Copy link
Contributor

LucasHill commented Jun 25, 2024

Fixed eslint v9 issues here: #2153

@Windvis
Copy link
Contributor

Windvis commented Sep 18, 2024

I think we should remove routes-segments-snake-case from the recommended set since the implicit route model hook has now been deprecated and that feature seemed to be the main motivation for this rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants