Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-implicit-injections has bugs when auto-fixing #2154

Open
elwayman02 opened this issue Jun 26, 2024 · 0 comments
Open

no-implicit-injections has bugs when auto-fixing #2154

elwayman02 opened this issue Jun 26, 2024 · 0 comments

Comments

@elwayman02
Copy link

  1. The added service injection doesn't format properly - it removes indents from the existing line it's inserted above
    Injection formatting

  2. The autofix tries to import the service decorator at the top of the file. It not only does so using the old deprecated syntax { inject as service }, but it fails to detect when the expected modern import { service } already exists and ends up incorrectly duplicating the imports.

Duplicate Import 1
Duplicate Import 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant