Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the setters into standard JS syntax #43

Open
suchitadoshi1987 opened this issue Mar 30, 2020 · 4 comments · May be fixed by #49
Open

Convert the setters into standard JS syntax #43

suchitadoshi1987 opened this issue Mar 30, 2020 · 4 comments · May be fixed by #49

Comments

@suchitadoshi1987
Copy link
Contributor

Convert simple cases of setters into standard JS syntax.

// Before
let chad = Person.create();
chad.set('firstName', 'Chad');
chad.set('lastName', 'Hietala');

// After
let chad = new Person();
chad.firstName = 'Chad';
chad.lastName = 'Hietala';
@rajasegar
Copy link
Member

@suchitadoshi1987 Is someone working on this?

@suchitadoshi1987
Copy link
Contributor Author

@rajasegar not at the moment, feel free to pick it up if you have some bandwidth :)

@rajasegar
Copy link
Member

OK I will pick it up then.

@rajasegar
Copy link
Member

You have also replaced create with new expression in your example, it is not part of the conversion right?

@rajasegar rajasegar linked a pull request Apr 4, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants