Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Translations break LdTabs #1093

Open
3 tasks done
mkilp opened this issue May 21, 2024 · 3 comments
Open
3 tasks done

bug: Translations break LdTabs #1093

mkilp opened this issue May 21, 2024 · 3 comments
Labels
solution provided A solution for the issue has been provided. stale There's been no activity for 60 days. The issue will be closed after 2 weeks unless active again.

Comments

@mkilp
Copy link

mkilp commented May 21, 2024

Prerequisites

Liquid version

5.14.0

Framework bindings

React

Current behavior

Using translations with Tabs causes the component to break on language change.

Expected behavior

Tabs still work even when language of tabs change.

Steps to reproduce

See Sandbox.
https://codesandbox.io/p/devbox/tabbed-bug-gjpsx5?file=%2Fsrc%2FApp.js%3A15%2C1

Code reproduction URL

https://codesandbox.io/p/devbox/tabbed-bug-gjpsx5?file=%2Fsrc%2FApp.js%3A15%2C1

Additional information

No response

@mkilp mkilp added bug An issue describing unexpected or malicious behaviour. triage An issue that needs assessment to determine its validity and urgency labels May 21, 2024
@renet
Copy link
Member

renet commented May 22, 2024

@mkilp It says "devbox not found". Can you please update the link or make it public, if that's the issue? =)

@mkilp
Copy link
Author

mkilp commented May 22, 2024

@renet sorry about that! I forgot to move it out of my drafts. Should be all set now.

@renet
Copy link
Member

renet commented May 22, 2024

@mkilp To me it looks like you're using the actual translation value (e.g. "Blank Label" or "Leeres Etikett") instead of the translation key (i.e. "new-label-modal.tabs.tab-1-title") as "labelType", that's why the current value does no longer match, when you change language. I changed the code so that it works, hope this helps: https://codesandbox.io/p/devbox/tabbed-bug-forked-zfphmc

@renet renet added stale There's been no activity for 60 days. The issue will be closed after 2 weeks unless active again. solution provided A solution for the issue has been provided. and removed bug An issue describing unexpected or malicious behaviour. triage An issue that needs assessment to determine its validity and urgency labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution provided A solution for the issue has been provided. stale There's been no activity for 60 days. The issue will be closed after 2 weeks unless active again.
Projects
None yet
Development

No branches or pull requests

2 participants