Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Refactor ld-select.tsx as it's almost 1,500 lines big now #919

Open
3 tasks done
borisdiakur opened this issue Aug 29, 2023 · 0 comments
Open
3 tasks done
Labels
improvement Not a bug nor a feature. Refactoring of code would likely have this label.

Comments

@borisdiakur
Copy link
Contributor

Prerequisites

Liquid version

5.11.1

Framework bindings

no bindings

Current behavior

All the code for the ld-select component is in ld-select.tsx. We have to scroll and use search a lot when working on the component.

Expected behavior

The component should be small and contain only the core functionality. Helper functions and feature specific methods should be put in separate files.

In a second step (after separating the big file into multiple small ones) we should check if it makes sense to import parts of the code dynamically, depending on whether a feature is being used or not.

Steps to reproduce

Code reproduction URL

Additional information

No response

@borisdiakur borisdiakur added the improvement Not a bug nor a feature. Refactoring of code would likely have this label. label Aug 29, 2023
@borisdiakur borisdiakur mentioned this issue Aug 29, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a bug nor a feature. Refactoring of code would likely have this label.
Projects
None yet
Development

No branches or pull requests

1 participant