Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing nested groups #23

Closed
unlessgames opened this issue Jun 22, 2024 · 1 comment · Fixed by #24
Closed

Parsing nested groups #23

unlessgames opened this issue Jun 22, 2024 · 1 comment · Fixed by #24
Labels
bug Something isn't working

Comments

@unlessgames
Copy link
Collaborator

As mentioned on the forum, parsing expressions like [ [ [ [ ] ] ] ] takes a long time for pest with the current rules.

I found this issue on the pest github that seems relevant.

Clearly the rules inside groups have some similar retrying that was mentioned on the issue as for example a stack can have a split or a section inside while a group can have a stack, split or section but I'm not sure how we could optimize this exactly and profiling might be a good idea before trying to do anything here.

@emuell
Copy link
Owner

emuell commented Jun 22, 2024

This seems to be s general Pest issue after all.

See also martinohmann/hcl-rs#82

Let me know if I can help setting up some benchmarks or writing a guide on how to profile this. I can try taking care of this issue too next week if you don't have time for that.

@emuell emuell added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants