Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate <h1> from native examples #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martymcguire
Copy link

Running the native example was producing invalid HTML with nested <h1>s:

<my-header enhanced="">  
    <h1><h1>Hello World</h1></h1></my-header>

my-header.php wraps the <slot> in an <h1> in both the native and WASM examples.

This PR updates the native $htmlString example in both the README and index.php to remove the extra <h1>.

(`my-header.php` wraps the `<slot>` in an `<h1>` already)
Copy link

github-actions bot commented Sep 4, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@martymcguire
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

macdonst added a commit to enhance-dev/.github that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant