Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace roundLengthInSeconds with roundLength #5

Open
domenukk opened this issue Apr 25, 2021 · 3 comments
Open

Replace roundLengthInSeconds with roundLength #5

domenukk opened this issue Apr 25, 2021 · 3 comments
Labels
discussion To discuss

Comments

@domenukk
Copy link
Member

domenukk commented Apr 25, 2021 •
edited
Loading

We have decided to go with milliseconds everywhere, so ctf.json should probably be changed to reflect this decision.
@Trolldemorted
Copy link
Member

*everywhere in the m2m interfaces

@domenukk
Copy link
Member Author

So you argue for inconsistency, and against the added precision, in this case, to save a simple multiplication? Or was this comment solely informational?

@Trolldemorted
Copy link
Member

This is no inconsistency, this is a different spec only transitively related to the enochecker API. If you can convince the users of EnoEngine that this is a good idea we can do it /shrug

@domenukk domenukk assigned domenukk and unassigned domenukk May 22, 2021
@domenukk domenukk added the discussion To discuss label May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion To discuss
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenukk @Trolldemorted