Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[youtube][watch]: Display playlist runtime in playlist panel of watch page #4

Open
1 task done
DarhkVoyd opened this issue Sep 29, 2023 · 16 comments
Open
1 task done
Assignees
Labels
Status: Available Ready to be taken up for work or review Type: Enhancement New feature or request

Comments

@DarhkVoyd
Copy link
Member

DarhkVoyd commented Sep 29, 2023

Issue Type

  • Feature Request

Description

Currently, the playlist runtime information is displayed in the metadata section of the playlist page. However, it would be great to also show this information in the playlist panel of the watch video page for that playlist. This feature would provide easier access to playlist runtime details without the need to navigate to the playlist page.

Expected Behavior

When viewing a video within a playlist, the runtime information for that playlist should be displayed within the playlist panel on the watch page.

Current Behavior

At present, the playlist runtime information is only visible in the metadata section of the playlist page. Users must navigate to this playlist page to view playlist runtime details.

@DarhkVoyd DarhkVoyd added Type: Enhancement New feature or request Status: Available Ready to be taken up for work or review labels Sep 29, 2023
@yakatyansh
Copy link

I would like to work on it

@DarhkVoyd
Copy link
Member Author

Hey @yakatyansh,

Thank you for showing interest in contributing to Toppings. However, I want to inform you that this particular issue is currently on hold as we're waiting to address some design-related changes, and it's not part of our Hacktoberfest goals this year.

We appreciate your enthusiasm, and we encourage you to keep an eye on our project for future opportunities to contribute.

I am removing the "ready to take" label to reflect that.

@DarhkVoyd DarhkVoyd removed the Status: Available Ready to be taken up for work or review label Oct 1, 2023
@yakatyansh
Copy link

We appreciate your enthusiasm, and we encourage you to keep an eye on our project for future opportunities to contribute.

I am removing the "ready to take" label to reflect that.

sure, will keep an eye on this issue and would love to create issues if I find any on testing

@Sandesh-03
Copy link

assign this issue to me

@DarhkVoyd
Copy link
Member Author

@yakatyansh This issue is now ready to take, If you are still interested in working on it.

@DarhkVoyd DarhkVoyd added the Status: Available Ready to be taken up for work or review label Oct 14, 2023
@yakatyansh
Copy link

Yes would love to

@DarhkVoyd
Copy link
Member Author

@yakatyansh I've assigned the issue to you. If you have any questions or need assistance along the way, feel free to ask.

@yakatyansh
Copy link

so sorry it is taking time, am sick lately, but working on the issue rn

@DarhkVoyd
Copy link
Member Author

DarhkVoyd commented Oct 22, 2023

@yakatyansh No problem at all! Your health comes first. Just keep us informed when you're back at it, and take all the time you need. We appreciate your efforts and look forward to your updates.

@yakatyansh
Copy link

Hey, I am better after a series of festivals and sickness, from today I will work on it properly, I just wanted to know that how to access the metadata section

@DarhkVoyd
Copy link
Member Author

DarhkVoyd commented Oct 26, 2023

Hey, you could possibly start by looking at the implementation of addMetadataToppings in routeType/playlist to better understand how it was implemented there and then similarly implement for routeType/watch.
https://github.com/enrich-platforms/toppings/blob/e6e9070788afe8a412f57c5aa8cebee1647e225c/src/scripts/youtube/routeType/playlist/addMetadataToppings.ts#L20
You could also use these css styles implemented here or write your own to better blend into YouTube's native UI.

Since, this will be a new feature in routeType/watch, you might also need to extract the playlist id from the webApp and pass it down to watch page component and fetch API there.

If you have any further questions, feel free to ask.

@yakatyansh
Copy link

Thank you for the great explaination, I am now quite clear about what to do here
Screenshot 2023-10-28 at 2 50 17 PM
so, this piece of UI
Screenshot 2023-10-28 at 2 51 03 PM
needs to go here,

@DarhkVoyd
Copy link
Member Author

DarhkVoyd commented Oct 28, 2023

@yakatyansh Yes, exactly. You should make sure that the styles blend seamlessly in YouTube's UI, so instead of a card like in the metadata section, you could do try and test various styles such as simply just adding it as plain information below title. Or some other styles and go with what suits best here.

@yakatyansh
Copy link

image

what do you think about this implementation ?, I am trying new things, because it is my first time implementing something on the YouTube UI

@DarhkVoyd
Copy link
Member Author

DarhkVoyd commented Nov 2, 2023

@yakatyansh, could you please create a draft pull request (PR) for your changes? This will make it easier for us to review your code. Additionally, since the codebase has recently undergone significant refactoring and restructuring, I recommend syncing your fork if you haven't already. Thanks!

@yakatyansh
Copy link

yakatyansh commented Nov 8, 2023

yes regularily syncing the fork, and working on the draft pr, actually somehow I lost my progress, so will have to do it again 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Available Ready to be taken up for work or review Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants