Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content field does not allow to pass cidv1 hash for ipfs hashes #601

Closed
wighawag opened this issue Feb 24, 2020 · 6 comments
Closed

content field does not allow to pass cidv1 hash for ipfs hashes #601

wighawag opened this issue Feb 24, 2020 · 6 comments
Assignees

Comments

@wighawag
Copy link

The current website does not allow me to enter ipfs hash in cidv1 format like ipfs://bafybeidkapzich7dcpsouvpuv4vm6gf5mniohqwir2xvo4mldvxkrgtwva

cidv1_ens

@jefflau
Copy link
Member

jefflau commented Mar 3, 2020

@pldespaigne Is this something that needs to be updated in the contenthash library?

@pldespaigne
Copy link
Contributor

everything is here ^^
#538

@jefflau
Copy link
Member

jefflau commented Mar 9, 2020

@pldespaigne Apologies, the migration stuff was crazy - will get @makoto to catch up on it ASAP!

@makoto
Copy link
Member

makoto commented Mar 9, 2020

hey, @pldespaigne sorry for taking ages for taking a look. Would you mind describing what and how I should test? I just did the following 2 tests and both are failing.

  1. Trying to set ipfs://bafybeidkapzich7dcpsouvpuv4vm6gf5mniohqwir2xvo4mldvxkrgtwva in content section shows an error message (just like @wighawag is encountering). Would ui change PR actually allow to encode cidv1?

  2. Trying to set the cidv0 (ipfs://QmaEBknbGT4bTQiQoe2VNgBJbRfygQGktnaW5TbuKixjYL) will allow me to send a transaction to set the content in ENS, but now decoding as empty when displaying as it is throwing at contents.js:91 Error encoding content hash. If you remove try/catch, it is actually failing to decode at encoded = '0x' + contentHash.fromIpfs(content).

@brantlymillegan
Copy link
Contributor

Hey @pldespaigne, just checking on this. Any ideas re Makoto's questions above?

@makoto
Copy link
Member

makoto commented May 11, 2020

Closing due to inactivity

@makoto makoto closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants