Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registrar.js calling makeCommitmentWithConfig that's not available in latest contract on github. #172

Open
gaurav-gupta opened this issue Aug 25, 2022 · 0 comments

Comments

@gaurav-gupta
Copy link

In Registrar.js, method async makeCommitment(name, owner, secret = '') calls to get address for resolver.eth.

async getAddress(name) {
const provider = await getProvider()
const hash = namehash(name)
const resolverAddr = await this.ENS.resolver(hash)
const Resolver = getResolverContract({ address: resolverAddr, provider })
return Resolver'addr(bytes32)'
}

if we don't create resolver.eth domain, last line of getAddress throws error. So i set resolver.eth domain in my contract.

Now makeCommitment tries to call the method permanentRegistrarController.makeCommitmentWithConfig(
name,
owner,
secret,
resolverAddr,
account
)

Which doesn't exist in latest ETHRegistrarController. It's available in ENS deployment at https://goerli.etherscan.io/address/0x283Af0B28c62C092C9727F1Ee09c02CA627EB7F5#code but not in the code available on github. So makeCommitment method goes to meatmask and it returns error
fromPromise error: Error: missing revert data in call exception; Transaction reverted without a reason string [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (error={"code":-32000,"message":"execution reverted"}, data="0x", code=CALL_EXCEPTION, version=providers/5.6.5)

Please fix this in UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant