Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate (non-) matching during import #1023

Open
morremeyer opened this issue Aug 7, 2023 · 0 comments
Open

Indicate (non-) matching during import #1023

morremeyer opened this issue Aug 7, 2023 · 0 comments
Labels
enhancement New feature or improvements to an existing one

Comments

@morremeyer
Copy link
Member

Is your feature request related to a problem? Please describe.
When importing, it is hard to discern if an account is being created for this transaction or if it already exists.
When it is matched by a rename rule, it's impossible to know which rule matched the transaction.

@fhreichert requested this in envelope-zero/backend#738, for which the backend part was implemented in envelope-zero/backend#737.

The transaction preview resource now has a renameRuleId field that is either the zero UUID if none matched or contains the ID of the rename rule that was applied.

Describe the solution you'd like

There are three possible states for the opposing account in an import preview:

  • It was matched exactly by name. (Account ID is set, renameRule ID is zero). In this case, there should be context information showing that this was the case
  • It was matched by a renameRule. (Account ID and renameRule ID are both set). In this case, there should be context information linking to the renameRule (list?))
  • It was not matched at all. (Account ID and renameRule ID are both zero). In this case, there should be an accessible indication that importing this transaction would create a new opposing account
@morremeyer morremeyer added the enhancement New feature or improvements to an existing one label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvements to an existing one
Projects
None yet
Development

No branches or pull requests

1 participant