Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Changing the way errors looks on editTexts #875

Open
cdhiraj40 opened this issue Dec 14, 2021 · 5 comments
Open

[Discussion] Changing the way errors looks on editTexts #875

cdhiraj40 opened this issue Dec 14, 2021 · 5 comments

Comments

@cdhiraj40
Copy link
Contributor

cdhiraj40 commented Dec 14, 2021

As the app already uses google's material TextInputLayout, it also should use its great-looking way to show errors.
there are places where showing error takes space in editText and it makes it look bad because of compression.
for example:
before-ss1

some screenshots of after using material TextInputLayout way to show error

CarSelectionAttributes Fragment HSN/TSN Fragment
ss3 ss2
ss1

@SebaDro @asaikarthikeya what are your thoughts on this way to show an error?
would like to hear your thoughts
[using this issue as a discussion]

another thought: we can use discussions given by GitHub, so every time a person wants to request a new feature they can propose in discussions, and once approved they can create a new issue

I think it will help in decreasing the stale issues which are not required to work for now :)

@asaikarthikeya
Copy link
Member

@cdhiraj40 hey, Yes. Your new proposed way of showing errors looks good to me. Showing error icon seem to be bit outdated and the compression is also observed in few devices. If you would like to work on this issue, please create a PR. Thanks.

@cdhiraj40
Copy link
Contributor Author

@cdhiraj40 hey, Yes. Your new proposed way of showing errors looks good to me. Showing error icon seem to be bit outdated and the compression is also observed in few devices. If you would like to work on this issue, please create a PR. Thanks.

sure I would definitely like to work on this, you can assign me :)

@asaikarthikeya
Copy link
Member

asaikarthikeya commented Dec 14, 2021

Generally for any issue, the PR which is raised first is considered. Other PR's which are created later will be not considered. As you have already mentioned your interest in this issue, any other developer should have to confirm with you before he works on this issue. So, No need to wait until it is assigned to you. You can work on any issue if it does not have a open PR ;) Thanks.

@pree-T
Copy link

pree-T commented Dec 24, 2021

May I work on it?

@cdhiraj40
Copy link
Contributor Author

hey @pree-T I have already made PR for this #876
I would suggest you, find some issues which have no PRs linked to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants