-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] Changing the way errors looks on editTexts #875
Comments
@cdhiraj40 hey, Yes. Your new proposed way of showing errors looks good to me. Showing error icon seem to be bit outdated and the compression is also observed in few devices. If you would like to work on this issue, please create a PR. Thanks. |
sure I would definitely like to work on this, you can assign me :) |
Generally for any issue, the PR which is raised first is considered. Other PR's which are created later will be not considered. As you have already mentioned your interest in this issue, any other developer should have to confirm with you before he works on this issue. So, No need to wait until it is assigned to you. You can work on any issue if it does not have a open PR ;) Thanks. |
May I work on it? |
As the app already uses google's material TextInputLayout, it also should use its great-looking way to show errors.
there are places where showing error takes space in editText and it makes it look bad because of compression.
for example:
some screenshots of after using material TextInputLayout way to show error
@SebaDro @asaikarthikeya what are your thoughts on this way to show an error?
would like to hear your thoughts
[using this issue as a discussion]
another thought: we can use discussions given by GitHub, so every time a person wants to request a new feature they can propose in discussions, and once approved they can create a new issue
I think it will help in decreasing the stale issues which are not required to work for now :)
The text was updated successfully, but these errors were encountered: