Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestConfig.StringAccessors seems to be flaky #2641

Open
RyanTheOptimist opened this issue Oct 31, 2022 · 0 comments
Open

TestConfig.StringAccessors seems to be flaky #2641

RyanTheOptimist opened this issue Oct 31, 2022 · 0 comments
Assignees
@RyanTheOptimist
Labels
area/testing issues for improving testing of the library

Comments

@RyanTheOptimist
Copy link
Contributor

TestConfig.StringAccessors seems to be flaky, or at least fragile. I got a test failure in an unrelated PR recently:

[2022-10-31 13:02:05.770][13641667][critical][assert] [external/envoy/test/test_listener.cc:21] assert failure: !Thread::MainThread::isMainThreadActive(). Details: MainThreadLeak: [TestConfig.StringAccessors] test exited before main thread shut down

https://github.com/envoyproxy/envoy-mobile/actions/runs/3322946043/jobs/5571794275

Doing some local testing, I noticed that if I re-order the tests in envoy_config_test.cc so that this test does not run last, then it causes failures reliably.
@RyanTheOptimist RyanTheOptimist added the area/testing issues for improving testing of the library label Oct 31, 2022
@RyanTheOptimist RyanTheOptimist self-assigned this Oct 31, 2022
@RyanTheOptimist RyanTheOptimist mentioned this issue Oct 31, 2022
Merged
RyanTheOptimist added a commit that referenced this issue Oct 31, 2022
@RyanTheOptimist
Disable flaky TestConfig.StringAccessors (#2642)
8d3024b 
Disable flaky TestConfig.StringAccessors util the cause of flakiness is addressed.

#2641
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Ryan Hamilton [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanTheOptimist RyanTheOptimist

Labels
area/testing issues for improving testing of the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RyanTheOptimist