Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android, c++: add a way to enable proxy support to c++ engine builder #25076

Open
Augustyniak opened this issue Jan 20, 2023 · 2 comments
Open

android, c++: add a way to enable proxy support to c++ engine builder #25076

Augustyniak opened this issue Jan 20, 2023 · 2 comments
Labels
enhancement Feature requests. Not bugs or questions. mobile no stalebot Disables stalebot from closing an issue

Comments

@Augustyniak
Copy link
Contributor

Title: Add a way to enable proxy support to c++ engine builder

Description:
The current implementation for supporting proxies on Android depends on AndroindEngineImpl being used. That class is not used by engine_builder.cc even if it's used on Android platform. Change the setup so that Envoy engines created with the use of engine_builder.cc respect system proxy settings.

Relevant Links:
envoyproxy/envoy-mobile#2547
@Augustyniak Augustyniak added enhancement Feature requests. Not bugs or questions. triage Issue requires triage mobile and removed triage Issue requires triage labels Jan 20, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 20, 2023
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2023
@Augustyniak Augustyniak added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Mar 7, 2023
@Augustyniak Augustyniak reopened this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests. Not bugs or questions. mobile no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Augustyniak