From 48c44a87a27668379d6cfc893724f4e55b48efb3 Mon Sep 17 00:00:00 2001 From: bitliu Date: Thu, 7 Dec 2023 17:32:22 +0800 Subject: [PATCH 1/3] feat: welcome comment and auto cc gateway reviewers Signed-off-by: bitliu --- .github/workflows/welcome.yaml | 40 ++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 .github/workflows/welcome.yaml diff --git a/.github/workflows/welcome.yaml b/.github/workflows/welcome.yaml new file mode 100644 index 00000000000..51659033469 --- /dev/null +++ b/.github/workflows/welcome.yaml @@ -0,0 +1,40 @@ +name: Welcome + +on: + pull_request_target: + types: [opened] + +jobs: + comment: + permissions: + pull-requests: write + runs-on: ubuntu-latest + steps: + - name: Comment + uses: peter-evans/create-or-update-comment@v3 + with: + issue-number: ${{ github.event.pull_request.number }} + body: | + 🚀 Thank you for contributing to the [Envoy Gateway](https://gateway.envoyproxy.io) project! 🚀 + + Your PR has been successfully submitted, and we greatly appreciate your effort and contribution. Before merging, please ensure to follow the process below: + + 1. **Requesting Reviews**: + - cc @envoyproxy/gateway-reviewers team for an initial review. + - After the initial review, reviewers should request the @envoyproxy/gateway-maintainers team for further review. + + 2. **Review Approval**: + - Your PR needs to receive at least **two** approvals. + - At least **one** approval must come from a member of the gateway-maintainers team. + + Our [Build and Test Workflow](https://github.com/envoyproxy/gateway/actions/workflows/build_and_test.yaml) will run a series of checks on your code to ensure it meets our quality standards and coding conventions. In the meantime, you can help expedite the processing of your PR by: + - Ensuring you have self-reviewed your work according to the project's [Contribution Guidelines](https://gateway.envoyproxy.io/latest/contributions/develop). + - If your PR addresses a specific issue, make sure to mention it in the PR description. + - Respond promptly if there are any test failures or suggestions for improvements that we comment on. + + Envoy Gateway team will review your PR as soon as possible. If all goes well, your code will soon be merged into the main branch. Should further modifications be required or if there are any questions, we will communicate with you in the PR comments. + + Thank you once again for your contribution, we look forward to your excellent code bringing more possibilities to the Envoy Gateway! + + Happy coding! + reactions: 'heart' From 2e760ffcfe64491a5f510fc661e8fb4b6b52dda7 Mon Sep 17 00:00:00 2001 From: bitliu Date: Fri, 8 Dec 2023 10:30:31 +0800 Subject: [PATCH 2/3] update Signed-off-by: bitliu --- .github/workflows/welcome.yaml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/welcome.yaml b/.github/workflows/welcome.yaml index 51659033469..1f606298043 100644 --- a/.github/workflows/welcome.yaml +++ b/.github/workflows/welcome.yaml @@ -15,26 +15,26 @@ jobs: with: issue-number: ${{ github.event.pull_request.number }} body: | - 🚀 Thank you for contributing to the [Envoy Gateway](https://gateway.envoyproxy.io) project! 🚀 + 🚀 Thank you for contributing to the [Envoy Gateway](https://gateway.envoyproxy.io/) project! 🚀 - Your PR has been successfully submitted, and we greatly appreciate your effort and contribution. Before merging, please ensure to follow the process below: + Before merging, please ensure to follow the process below: - 1. **Requesting Reviews**: - - cc @envoyproxy/gateway-reviewers team for an initial review. - - After the initial review, reviewers should request the @envoyproxy/gateway-maintainers team for further review. + 1. Requesting Reviews: + - cc @envoyproxy/gateway-reviewers team for an initial review. + - After the initial review, reviewers should request the @envoyproxy/gateway-maintainers team for further review. + 2. Review Approval: + - Your PR needs to receive at least two approvals. + - At least one approval must come from a member of the gateway-maintainers team. - 2. **Review Approval**: - - Your PR needs to receive at least **two** approvals. - - At least **one** approval must come from a member of the gateway-maintainers team. + **NOTE**: Once your PR is under review, ***please do not rebase and force push it***. Otherwise, it will force your reviewers to review the PR from scratch rather than simply look at your latest changes. + +
+ What's more, you can help expedite the processing of your PR by +
- Our [Build and Test Workflow](https://github.com/envoyproxy/gateway/actions/workflows/build_and_test.yaml) will run a series of checks on your code to ensure it meets our quality standards and coding conventions. In the meantime, you can help expedite the processing of your PR by: - Ensuring you have self-reviewed your work according to the project's [Contribution Guidelines](https://gateway.envoyproxy.io/latest/contributions/develop). - If your PR addresses a specific issue, make sure to mention it in the PR description. - Respond promptly if there are any test failures or suggestions for improvements that we comment on. - Envoy Gateway team will review your PR as soon as possible. If all goes well, your code will soon be merged into the main branch. Should further modifications be required or if there are any questions, we will communicate with you in the PR comments. - - Thank you once again for your contribution, we look forward to your excellent code bringing more possibilities to the Envoy Gateway! - - Happy coding! +
reactions: 'heart' From 009c2d18dc3fdff400251f36de8d4fc023f34218 Mon Sep 17 00:00:00 2001 From: bitliu Date: Fri, 8 Dec 2023 10:58:55 +0800 Subject: [PATCH 3/3] fix lint Signed-off-by: bitliu --- .github/workflows/welcome.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/welcome.yaml b/.github/workflows/welcome.yaml index 1f606298043..750c36f1c1d 100644 --- a/.github/workflows/welcome.yaml +++ b/.github/workflows/welcome.yaml @@ -26,7 +26,7 @@ jobs: - Your PR needs to receive at least two approvals. - At least one approval must come from a member of the gateway-maintainers team. - **NOTE**: Once your PR is under review, ***please do not rebase and force push it***. Otherwise, it will force your reviewers to review the PR from scratch rather than simply look at your latest changes. + **NOTE**: Once your PR is under review, ***please do not rebase and force push it***. Otherwise, it will force your reviewers to review the PR from scratch rather than simply look at your latest changes.
What's more, you can help expedite the processing of your PR by