Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all internal columns, in particular forecast_id, more robust by prefixing it with "scoringutils_" #927

Open
nikosbosse opened this issue Sep 26, 2024 · 1 comment
Labels
good first issue Good for newcomers high-priority Should be addressed soon

Comments

@nikosbosse
Copy link
Contributor

quantile_to_interval_numeric(), for example, makes use of an internal forecast_id column. This might cause issues if there is already a forecast_id column in the input.

We should likely prefix all internal columns with "scoringutils_" to avoid those issues + document this design choice somewhere.

@seabbs
Copy link
Contributor

seabbs commented Sep 27, 2024

Yes makes sense though seems a little long. I typically use . As a prefix but people might conceivably name their variables using a dot

@nikosbosse nikosbosse added this to the scoringutils-2.x milestone Sep 27, 2024
@nikosbosse nikosbosse added high-priority Should be addressed soon good first issue Good for newcomers labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers high-priority Should be addressed soon
Projects
Status: No status
Development

No branches or pull requests

2 participants