Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_metrics() more customisable #944

Open
nikosbosse opened this issue Oct 8, 2024 · 1 comment
Open

Make get_metrics() more customisable #944

nikosbosse opened this issue Oct 8, 2024 · 1 comment
Labels
enhancement New feature or request feature request

Comments

@nikosbosse
Copy link
Contributor

We could add additional functions / additional arguments to get_metrics(). Consider something like this:

get_metrics(
  example_quantile, 
  exclude = c("ae_median"), 
  replace = c(wis, purrr::partial(wis, na.rm = TRUE), 
  add_args = c(wis, list(na.rm = TRUE))

or something like this. Not so sure about add_args, but replace could actually be nice?

maybe related: #789

@nikosbosse nikosbosse added enhancement New feature or request feature request labels Oct 8, 2024
@nikosbosse nikosbosse added this to the scoringutils-2.x milestone Oct 8, 2024
@seabbs
Copy link
Contributor

seabbs commented Oct 8, 2024

Hmm yeah maybe... I think my preference would be modular functions for this (i.e you would chain get_metrics into a series of transforms etc) but I don't feel that strongly/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request
Projects
Development

No branches or pull requests

2 participants