"Public" libres API changes #2239
pinkwah
started this conversation in
Libres Payback
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Move all internal structs in libres to public header files. This will help us instantly remove most getters/setters used by C code.
Some setters need to allocate strings osv. Replace
char*
withstd::string
.In Python cwrap code, consider using
ctypes.Struct
to define the struct in Python, and then get the struct members directly, rather than using getters.Use
new
/delete
rather thanmalloc
/free
in_alloc
and_free
functions.If possible, do the jump directly to pybind11-backed C++ classes.
Beta Was this translation helpful? Give feedback.
All reactions