Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We do not wait until test server has loaded #1172

Open
anders-kiaer opened this issue Nov 22, 2022 · 0 comments
Open

We do not wait until test server has loaded #1172

anders-kiaer opened this issue Nov 22, 2022 · 0 comments
Labels
good first issue Good for newcomers maintenance

Comments

@anders-kiaer
Copy link
Collaborator

We currently use this test pattern

webviz-subsurface/tests/integration_tests/plugin_tests/test_reservoir_simulation_timeseries_regional.py

Lines 21 to 23 in 1302ce1

app.layout = plugin.layout
dash_duo.start_server(app)
assert dash_duo.get_logs() == []

This does not ensure that we wait until the server/plugin has loaded, so there might be console logs we don't see because we assert too early.
@anders-kiaer anders-kiaer moved this to Backlog 📝 in Webviz Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintenance
Projects
Webviz
Status: Backlog 📝
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anders-kiaer