Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File names and locations #5

Open
AdamLaine opened this issue Aug 22, 2022 · 3 comments
Open

File names and locations #5

AdamLaine opened this issue Aug 22, 2022 · 3 comments

Comments

@AdamLaine
Copy link
Collaborator

AdamLaine commented Aug 22, 2022

@erickahmed I propose a small thing to do to simplify the process for a lot of people. Sorry, but the file names and locations of the files are a little bit of a mess.
In any case we are now checking for the bugs, so any changes are better now than later, so I propose to group the files, some of them to rename and even some of them to delete or return to the normal functionality (see /gates/xnor.v to understand what I mean). In such a way we also don't need to write separate testbenches for every file, but just to the group to test.
Though there will be a problem that this proposition will break a lot of dependencies. If you agree, I'll do it and repair possible dependency failures (or postpone some of them if a file needs a complete redoing).

@erickahmed
Copy link
Owner

Actually I thought about it, and I agree that the file structure is a bit messy
Go ahead with the necessary changes, I won't push anything meanwhile, and continue my work after I've pulled the new directories (so there won't be a giant merge conflict)

And yes, this will be more efficient if it means that we need less testbenches

@AdamLaine
Copy link
Collaborator Author

@erickahmed May I ask you about the naming I have proposed in the PR? I would like to know what do you think. And if yes, in the next PR I'll upload maybe some prototype test benches with the renamed files.

@erickahmed
Copy link
Owner

@SamReiCooper I actually like it more than the previous naming convention I used, the names are far more intuitive now!
Also I wrote some testbenches but I had some weird issues with icarus-verilog (but it's probably something wrong with the way I reinstalled it). I'm going to do some test bench prototypes as well when I do resolve this thing

@AdamLaine AdamLaine removed their assignment Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants