Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Gas Values in OTS Search Tests #12248

Open
tosettil-polimi opened this issue Oct 8, 2024 · 0 comments
Open

Incorrect Gas Values in OTS Search Tests #12248

tosettil-polimi opened this issue Oct 8, 2024 · 0 comments
Labels
bug Something isn't working erigon3

Comments

@tosettil-polimi
Copy link
Collaborator

Incorrect Gas Values in OTS Search Tests

Description

The commit e3: cumulative gas used: as a domain (#12012) has introduced a bug that affects the gas values in the test cases for ots_searchTransactionsAfter and ots_searchTransactionsBefore.

Affected Tests

  • Test 14 in ots_searchTransactionsAfter
  • Test 14 in ots_searchTransactionsBefore

QA - RPC Integration Tests #161

Error Details

The test results show a discrepancy in the cumulativeGasUsed and gasUsed values:

12c12
<         "cumulativeGasUsed": "0x1be92",
---
>         "cumulativeGasUsed": "0x1f92a",
15c15
<         "gasUsed": "0x1be92",
---
>         "gasUsed": "0x1f92a",

Expected values:

  • cumulativeGasUsed:0x1be92 (114322 in decimal)
  • gasUsed:0x1be92 (114322 in decimal)

Actual values:

  • cumulativeGasUsed: 0x1f92a (129322 in decimal)
  • gasUsed: 0x1f92a (129322 in decimal)

Possible Cause

The commit may have altered the gas calculation logic or introduced changes that affect the transaction processing in the OTS
module.

Suggested Next Steps

  1. Review the changes introduced in the commit, focusing on gas calculation and OTS-related code
  2. Verify if the new gas values are correct or if there's an unintended side effect
  3. If confirmed as a bug, revert the problematic changes or implement a fix
  4. Update the test cases if the new behaviour is intended

I'm currently investigating to figure out how to do an update to see if this is a bug or an expected change in the gas calculation.

@mriccobene mriccobene added the bug Something isn't working label Oct 8, 2024
@tosettil-polimi tosettil-polimi changed the title Bug: Incorrect Gas Values in OTS Search Tests Incorrect Gas Values in OTS Search Tests Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working erigon3
Projects
None yet
Development

No branches or pull requests

3 participants