Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export and load CA entries from both SystemRoot and System keychain on darwin #8813

Open
starbelly opened this issue Sep 14, 2024 · 3 comments
Assignees
Labels
enhancement team:PS Assigned to OTP team PS waiting waiting for changes/input from author

Comments

@starbelly
Copy link
Contributor

starbelly commented Sep 14, 2024

Is your feature request related to a problem? Please describe.
Currently, pubkey_os_cacerts will only load SystemRootCertificates.keychain via the export tool on mac os. This is reasonable, however many companies use an internal CA (or multiple) and install related certificates in System.keychain. It would be a nice to have, to export and load both, to save people time and energy when it comes to figuring out why a tls error occurs, when openssl, curl, etc. work fine.

Describe alternatives you've considered
At the moment, when the environment is darwin I export both, write the contents out to a file, and load said file. This works fine. As a better alternative, it would be nice to have public_key:load/1 take either a binary or a file name (as is the case today) to save a write to the file system.

Additional context
None.

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Sep 15, 2024
@starbelly
Copy link
Contributor Author

P.S. @IngelaAndin I can of course send up a PR for either or, but I wanted to make sure OTP team would accept it first.

@dgud
Copy link
Contributor

dgud commented Sep 20, 2024

Please do, I think we would accept either or, with some motivation.

I have closed one issue report about this on Darwin before, but when I asked about some motivation I got a link to a random old forum post.

@starbelly
Copy link
Contributor Author

@dgud I will open up two PRs, first the one to by default load both keychains, then a second for the ability to load via binary, as I do believe this would be quite useful.

@dgud dgud self-assigned this Sep 23, 2024
@RaimoNiskanen RaimoNiskanen added the waiting waiting for changes/input from author label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement team:PS Assigned to OTP team PS waiting waiting for changes/input from author
Projects
None yet
Development

No branches or pull requests

4 participants