Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRL cache key being the path part of the distribution endpoint leads to clash #8891

Open
zmstone opened this issue Oct 3, 2024 · 1 comment
Assignees
Labels
bug Issue is reported as a bug team:PS Assigned to OTP team PS

Comments

@zmstone
Copy link
Contributor

zmstone commented Oct 3, 2024

Describe the bug

The CRL cache key is the extracted path part of a CRL DP URI.

do_insert(URI, CRLs) ->
case uri_string:normalize(URI, [return_map]) of
#{scheme := "http", path := Path} ->
ssl_manager:insert_crls(string:trim(Path, leading, "/"), CRLs);

This leads to clash when two DPs share the same path.

To Reproduce

Test with two different client certificates, having the same CRL DP URI path.

Expected behavior

Work with multiple CRL DPs

Affected versions

ALL?

@zmstone zmstone added the bug Issue is reported as a bug label Oct 3, 2024
@u3s u3s added the team:PS Assigned to OTP team PS label Oct 3, 2024
@IngelaAndin IngelaAndin self-assigned this Oct 8, 2024
@IngelaAndin
Copy link
Contributor

Well the solution to that, should be using more parts of the URI in the key. I think using the host, and port parts should suffice. Will include it for next sprint planning to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is reported as a bug team:PS Assigned to OTP team PS
Projects
None yet
Development

No branches or pull requests

3 participants