Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default pool name #60

Open
benbro opened this issue Jun 6, 2022 · 6 comments
Open

default pool name #60

benbro opened this issue Jun 6, 2022 · 6 comments

Comments

@benbro
Copy link
Contributor

benbro commented Jun 6, 2022

The pool name is used to register the pid and find it:

gen_server:start_link({local, Pool}, ?MODULE, {Pool, PoolConfig1}, []).
erlang:whereis(Pool)

Having a default pool name is useful but isn't using 'default' as the default pool name dangerous?
That's a generic word and if any other app in the release will register a process with the same name it will break.
Will it be a good idea to change the default pool name to 'pgo_default_pool' or similar?

@tsloughter
Copy link
Collaborator

yuuuuuuuuuuuuup, haha. Thanks for calling it out.

@tsloughter
Copy link
Collaborator

I released 0.12.0 today but will fix this before any new release.

@benbro
Copy link
Contributor Author

benbro commented Jun 21, 2022

I don't see the 0.12.0 release on github.

@tsloughter
Copy link
Collaborator

@tsloughter
Copy link
Collaborator

Ah, I didn't push the tag you mean.

@benbro
Copy link
Contributor Author

benbro commented Jun 21, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants