Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add border-radius property to hX:target selectors #662

Open
1 task done
lumirlumir opened this issue Nov 25, 2024 · 3 comments
Open
1 task done

Suggestion: Add border-radius property to hX:target selectors #662

lumirlumir opened this issue Nov 25, 2024 · 3 comments
Assignees
Labels
accepted enhancement New feature or request

Comments

@lumirlumir
Copy link

What problem do you want to solve?

Hello, I noticed that when clicking the link button next to headings, the background-color changes, as shown in the screenshot below.

Image

However, I found that the border-radius for the hX:target selectors are not set to var(--border-radius);. This causes inconsistency in the visualization, as seen in the following screenshot.

Image

What do you think is the correct solution?

I suggest adding a border-radius: var(--border-radius); property to the hX:target selectors to enhance visual consistency.

Here’s a preview of the changes:

  • Before
    Image

  • After
    Image

Participation

  • I am willing to submit a pull request for this change.

Additional comments

I think adding a bit more top and bottom padding or margin could improve the UI. Just my opinion—feel free to take it into consideration!

@lumirlumir lumirlumir added the enhancement New feature or request label Nov 25, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 25, 2024
@Tanujkanti4441 Tanujkanti4441 moved this from Needs Triage to Triaging in Triage Dec 3, 2024
@Tanujkanti4441
Copy link
Contributor

Hi @lumirlumir, thanks for the issue, the idea seems good to me, let's take some more feedback from @eslint/website-team.

@Tanujkanti4441 Tanujkanti4441 moved this from Triaging to Feedback Needed in Triage Dec 3, 2024
@nzakas
Copy link
Member

nzakas commented Dec 3, 2024

Just a note that this would have to be done in the eslint repo because that's where the docs live.

@harish-sethuraman
Copy link
Member

harish-sethuraman commented Dec 3, 2024

Feel free to send a PR. The rounded corners are fine. I'm unsure how the margins and padding would look (if it will look better with existing UI) so would like other's feedback as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted enhancement New feature or request
Projects
Status: Ready to Implement
Development

No branches or pull requests

4 participants