Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[led_strip] Add support for bytes order other than GRB (IEC-123) #341

Open
pidpawel opened this issue Jun 13, 2024 · 0 comments · May be fixed by #344
Open

[led_strip] Add support for bytes order other than GRB (IEC-123) #341

pidpawel opened this issue Jun 13, 2024 · 0 comments · May be fixed by #344
Labels
Component: led_strip Type: Feature Request Feature request for a component

Comments

@pidpawel
Copy link

Is your feature request related to a problem?

Yes. My devboard has a WS2812 variant that seems to be using RGB format, instead of GRB one so all led_indicator animations are wrong.

Describe the solution you'd like.

It'd be ideal to add other pixel formats in led_pixel_format_t. ESPHome seems to be supporting any arbitrary format so probably support like this makes the most sense. https://github.com/esphome/esphome/blob/dev/esphome/components/esp32_rmt_led_strip/led_strip.cpp#L129

Describe alternatives you've considered.

In the meantime I'll probably add macrodefinitions for arbitrary colours in the code, with a comment why the order's changed.

Additional context.

No response

@pidpawel pidpawel added the Type: Feature Request Feature request for a component label Jun 13, 2024
@github-actions github-actions bot changed the title [led_strip] Add support for bytes order other than GRB [led_strip] Add support for bytes order other than GRB (IEC-123) Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: led_strip Type: Feature Request Feature request for a component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants