Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary \n at the end of the text session file. #2126

Open
DmitryAstafyev opened this issue Oct 22, 2024 · 0 comments
Open

Unnecessary \n at the end of the text session file. #2126

DmitryAstafyev opened this issue Oct 22, 2024 · 0 comments
Assignees
Labels
new newly created issue

Comments

@DmitryAstafyev
Copy link
Collaborator

DmitryAstafyev commented Oct 22, 2024

With any binary format chipmunk creates a text representation of the session file (stored in ~/.chipmunk/tmp. The thing is, chipmunks add to the end of the file unnecessary \n. It happens because:

// application/apps/indexer/session/src/handlers/observing/mod.rs
MessageStreamItem::Item(ParseYield::Message(item)) => {
    state.write_session_file(source_id, format!("{item}\n")).await?;
}

Right now no any bugs related to this have been detected. But in general, it's wrong and we should not have an extra \n at the end of the file to prevent incorrect calculation of row numbers by grabber.

To check:

  • open any binary file
  • visit ~/.chipmunk/tmp
  • check a text session file
@github-actions github-actions bot added the new newly created issue label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new newly created issue
Projects
None yet
Development

No branches or pull requests

2 participants