Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing Initial Guess to matcher_service node #16

Open
anuraj-rp opened this issue Oct 2, 2013 · 3 comments
Open

Providing Initial Guess to matcher_service node #16

anuraj-rp opened this issue Oct 2, 2013 · 3 comments
Labels

Comments

@anuraj-rp
Copy link

Hi,

Is there a way to provide initial guess as a starting point when two point-clouds are matched with the matcher_service node?

Regards
Anuraj

@stephanemagnenat
Copy link
Collaborator

Not yet, but patches are welcome to add this feature.

@anuraj-rp
Copy link
Author

Hi,

I have modified the source code of matcher_service.cpp on my branch so that it advertises the "match_clouds_with_guess" service.

I have tried using this service with my other application node and presently it seems to work.

But I am not sure if was the most elegant way to do it. I could try to improve it with some feedback.

@pomerlef
Copy link
Contributor

I scanned quickly through your branch, thanks a lot for contributing.

I would suggest to have a generic function that take could cover both cases 1) with initial guess or 2) without, which means using an identity matrix. And then, two small callback that use this function. That would reduce code duplication and maintenance later.

It is good that you manage to do the conversion from tf::Transformation to TransformationParameters. I would suggest you to enhance the wrapper for ROS (namely libpointmatcher_ros) with your functionnality so that others can used it.

You can check https://github.com/ethz-asl/ethzasl_icp_mapping/blob/master/libpointmatcher_ros/include/pointmatcher_ros/transform.h#L35

Thanks again for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants