Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column floor used in analysis yet not prepared during cleaning #9

Open
Gutschlhofer opened this issue Jan 30, 2023 · 3 comments
Open

Comments

@Gutschlhofer
Copy link
Contributor

Checking summary statistics I found that the column floor contains some -9 values in the final purchases and prices datasets. Then I saw that it is not included in the cleaning script.

@eyayaw
Copy link
Owner

eyayaw commented Jan 30, 2023

Hi Jackob,

That is right. It's not part of the hedonics either.

I do not remember now, but I find the floor variable not interesting or incomplete—not to mention it's only relevant for apartments—and instead went with num_floors. If you think otherwise, please send a pr.

Thank you.

@Gutschlhofer
Copy link
Contributor Author

It is part of the hedonics, that's why I was wondering:

"condition", "balcony", "garden", "kitchen", "floor"

But I have the feeling that the floor is very important in choosing apartments, no?

I'll probably get to it within the next week.

@eyayaw
Copy link
Owner

eyayaw commented Jan 31, 2023

Oh, that isn't good. I figured that now we have purchases of homes and apartments together. When I started, it was all home purchases (HK), and floor was not part of the hedonics. floor was added to the model later on—after we brought HK and WK together.
9fd1383?diff=split#diff-568adc9f961ec934b6a167525dd2d664d3db2097419790077d6ec2b19378f09e

Sorry for the artifacts, but we will add a few cleaning lines for floor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants