Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simon's code review #89

Open
simonryrie opened this issue Jul 12, 2023 · 0 comments
Open

Simon's code review #89

simonryrie opened this issue Jul 12, 2023 · 0 comments
Assignees
@zakkariyaa @hanleymark @FomasTreeman @cameochoquer

Comments

@simonryrie
Copy link

This one was a bit rushed so didn't have time to look deeply at the code!

App looks great! I like:

How you are using uuid for keys

Good TypeScript implementation

The MoodMap looks really cool

Spotify login working nicely

A couple of pedantic UI issues:

image
When I had not made a log for that day, the image was missing.

image
It would be nice if this said yourself not myself 🤓
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zakkariyaa zakkariyaa

@hanleymark hanleymark

@FomasTreeman FomasTreeman

@cameochoquer cameochoquer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zakkariyaa @hanleymark @FomasTreeman @cameochoquer @simonryrie