Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toms issues with your shiz #63

Open
FomasTreeman opened this issue Jun 21, 2023 · 0 comments
Open

toms issues with your shiz #63

FomasTreeman opened this issue Jun 21, 2023 · 0 comments

Comments

@FomasTreeman
Copy link

  • seed script plez

  • quant variable name? why not just qty or quantity

  • loads of redundant returns

  • 'navbar' could have been inside seperate component. (more abstraction) only whats dependent on each other be in the same place.

  • ineffiecient to link google fonts. rather than store locally

  • i like state to always be defined at the top level of a function ('change my mind') :)

  • birdcage.js could have two possible components for when birdcage is truthy and another for when its falsy. to remove multiple &&

  • to fix home.cy.test you may have to change the get('BirdCage') to be the selector for the html elements generated by nextjs as once its on the browser the wont exist, its transformed to html components

  • love styled-components

  • love you guys

  • love the styling

  • love the _app.js very clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant