Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review - Phoenix Egbie Ollie #13

Open
zz-hh-aa opened this issue Mar 25, 2024 · 0 comments
Open

Code review - Phoenix Egbie Ollie #13

zz-hh-aa opened this issue Mar 25, 2024 · 0 comments

Comments

@zz-hh-aa
Copy link

Nice website so far, looking forward to seeing how it develops!

README

[Does the README describe the project using the subheadings: Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?]

  • Nice widgets at the top
  • Shields haven't imported properly
  • Would have been useful to have more explanation about the SESSION_SECRET
  • List of features / functionality would be useful too

User stories

[Does the project meet the user stories for that week?]

  • Could put the user stories on the README too

Learning outcomes

[Does it demonstrate the learning outcomes for that week?]

  • In progress :)

UI bugs

[Can you see any obvious bugs or areas to improve?]

  • Spacing could be improved, increase height of divs
  • Could add a margin to left hand side
  • Hover cursor over buttons you can interact with (eg little calendar)
  • Submit button looks small in comparison to top row content

Instructions

[Does everything work as expected or were there missing instructions?]

File structure

[When you open the project in your editor, does the file structure make sense?]

  • File structure largely makes sense, however there are two src folders
  • Maybe use public instead of html as folder name
  • There are also two index.htmls

Flow of control

[ Can you you follow the different paths the code might take?]

Naming

[Do variables and functions have clear and descriptive names?]

General

  • Advisable to use Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant