Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide API for registering other functions. #5

Open
noahlz opened this issue Sep 11, 2017 · 2 comments
Open

Provide API for registering other functions. #5

noahlz opened this issue Sep 11, 2017 · 2 comments

Comments

@noahlz
Copy link

noahlz commented Sep 11, 2017

We are interested in using your library but would like to extend it to other types, for example Saddle Vecs.

For example, be able to define operators that are Map[String, Vec[Double] => Vec[Double]]

As it stands now, we have to fork your library, and rewrite object FunctionRegister to have two different function registers: OperatorDouble and OperatorVector

(Saddle is a Scala library for numeric operations not unlike Pandas - http://saddle.github.io/)

@noahlz
Copy link
Author

noahlz commented Sep 11, 2017

I've asked my colleague @fshao816 to submit a PR with a proposed change.

@facaiy
Copy link
Owner

facaiy commented Sep 12, 2017

You are welcome, @noahlz . Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants