Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Long" tests #79

Open
smartalecH opened this issue Jan 18, 2024 · 0 comments
Open

"Long" tests #79

smartalecH opened this issue Jan 18, 2024 · 0 comments
Assignees

Comments

@smartalecH
Copy link
Contributor

Now that fmmax has some updated vector field formulations, it would be good to rerun some longer, more exhaustive tests just to ensure things are as we expect. Here are some of the axes we should check:

  • All of the different vector field formulations (currently the tests includes mostly POL)
  • Complicated geometries with metals and metasurfaces (e.g. modify the uLED to include a random metasurface)
  • Convergence checks with increased Fourier terms and BZ points

By specifying a separate set of "long" (or expensive) tests, we don't have to run them with CI. Rather, we can just run them locally when a major change is made. If we see regressions, we can manually git bisect to find the root of the issue.

@smartalecH smartalecH self-assigned this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant