Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubble castsByParent unexpected behaviour with reverse param #2126

Open
savish28 opened this issue Jul 6, 2024 · 1 comment
Open

Hubble castsByParent unexpected behaviour with reverse param #2126

savish28 opened this issue Jul 6, 2024 · 1 comment
Labels
s-ready Ready to be picked up

Comments

@savish28
Copy link

savish28 commented Jul 6, 2024

What is the bug?
A concise, high level description of the bug and how it affects you
Hubble's castByParent HTTP endpoint returns an error with certain url params when reverse parameter is 1, works fine without reverse

How can it be reproduced? (optional)
v1/castsByParent?url=https%3A%2F%2Fwarpcast.com%2F~%2Fchannel%2Ftalent&reverse=1

returns

{
"errCode": "not_found",
"presentable": false,
"name": "HubError",
"code": 2,
"details": "could not get message with key: [1, 181, 227, 3, 250, 1, 112, 114, 111, 116, 111, 99, 111, 108, 6, 154, 117, 255, 187, 238, 129, 122, 84, 254, 17, 198, 78, 15, 145, 60]",
"metadata": {
"errcode": [
"not_found"
]
}
}

Additional context (optional)
Add any other context about the problem here.
Works fine with v1/castsByParent?url=https%3A%2F%2Fwarpcast.com%2F~%2Fchannel%2Ftalent

@github-actions github-actions bot added the s-triage Needs to be reviewed, designed and prioritized label Jul 6, 2024
@sds sds added s-ready Ready to be picked up and removed s-triage Needs to be reviewed, designed and prioritized labels Jul 9, 2024
@sds
Copy link
Member

sds commented Jul 9, 2024

Hey @savish28, this was reported in #2067 and we thought we fixed it in #2077, which was released in Hubble 1.13.3.

However, as you point out, introducing the reverse=1 param seems to break things. Adding @Wazzymandias since they might have context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s-ready Ready to be picked up
Projects
None yet
Development

No branches or pull requests

2 participants