From d30950508fc74239f7e90461e3490aad0395ae97 Mon Sep 17 00:00:00 2001 From: Paul Weidner Date: Wed, 11 Sep 2024 16:31:50 -0700 Subject: [PATCH] Require svelte-gantt ^4.4.2 and simplify addRows logic --- CHANGELOG.md | 1 + package-lock.json | 8 ++++---- package.json | 2 +- src/instance.js | 3 --- src/methods.js | 7 +------ 5 files changed, 7 insertions(+), 14 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 01aa14d..b6c9336 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Change addTasks method to accept an object with updateRange +- Require svelte-gantt ^4.4.2 ### Fixed diff --git a/package-lock.json b/package-lock.json index 70962a5..2cde269 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10,7 +10,7 @@ "license": "MIT", "dependencies": { "moment": "^2.30.1", - "svelte-gantt": "^4.4.0" + "svelte-gantt": "^4.4.2" }, "devDependencies": { "@eslint/js": "^9.6.0", @@ -2158,9 +2158,9 @@ } }, "node_modules/svelte-gantt": { - "version": "4.4.0", - "resolved": "https://registry.npmjs.org/svelte-gantt/-/svelte-gantt-4.4.0.tgz", - "integrity": "sha512-vWXlg15yflmxPNW6D4V06M8tD1PD5D+6ublVdGLVT3xu/zSTVrjc21B1NID8RcKWXLcNTkeMsOWpRQr42xLJ4g==", + "version": "4.4.2", + "resolved": "https://registry.npmjs.org/svelte-gantt/-/svelte-gantt-4.4.2.tgz", + "integrity": "sha512-c3scu15CbBuYKHhZFaUcj8bUw/yGGmpePVbukY0bLYwiTpDouDC1TDRFMqUueaIMtc9o6pPJaYlDsRA7+cd2Tw==", "dependencies": { "sirv-cli": "^2.0.2" }, diff --git a/package.json b/package.json index 96fb264..73da3be 100644 --- a/package.json +++ b/package.json @@ -21,6 +21,6 @@ }, "dependencies": { "moment": "^2.30.1", - "svelte-gantt": "^4.4.0" + "svelte-gantt": "^4.4.2" } } diff --git a/src/instance.js b/src/instance.js index 4ef65fe..45d26c6 100644 --- a/src/instance.js +++ b/src/instance.js @@ -71,9 +71,6 @@ const createInstance = ({ target, options = {}}) => { return { highlightPast: options.highlightPast, padding: options.padding, - // @todo Remove this.rows state. - // See https://github.com/ANovokmet/svelte-gantt/issues/231 - rows: [], timeline: new SvelteGantt({ target: target, props: {...default_props, ...options.props}, diff --git a/src/methods.js b/src/methods.js index 2dec672..7793d1b 100644 --- a/src/methods.js +++ b/src/methods.js @@ -1,11 +1,6 @@ // Helper function to add rows. export function addRows(rows) { - // @todo Remove this.rows state and use timeline.updateRows() once working. - // See https://github.com/ANovokmet/svelte-gantt/issues/231 - this.rows.push(...rows); - this.timeline.$set({ - rows: this.rows, - }); + this.timeline.updateRows(rows); } // Helper function to add tasks.