-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using default calender configuration not working #14
Comments
No, insert_default_calendar() along with a few other functions are omitted from file calendar/drivers/caldav/caldav_driver.php |
I'm not a developer, but I just managed to make it work again, by comparing the file I made a patch which works for me, but I do not know how to create a pull request, so I attached the file here. |
Nice work. I was able to get https://github.com/texxasrulez/Caldav_Calendar/ working, unfortunately the bug with timezones was a show stopper texxasrulez/caldav_calendar#19 |
Sorry, I posted it here, but actually the patch was created for the dotplex/roundcube_calendar fork (in the meanwhile, I managed to create my first pull request). |
I see. And do the timezones work for you? |
Yes, the .ics file I can download from Roundcube contains all timezone details. |
It works even with roundcube 1.4 (elastic - but only with larry or classic themes). I use docker (official) and had to additionally install mcrypt extension which became disabled in php 7.1 (and removed in php 7.2): https://askubuntu.com/questions/1031921/php-mcrypt-package-missing-in-ubuntu-server-18-04-lts The only trouble is the default time zone - caldav plugin converts the time to UTC timezone and does not save any info about the timezone.
E.g. new event 09:30-10:30 is shown as such in roundcube/calendar, and also in nextcloud calendar I can see 09:30-10:30 in the calendar view. Is there a way how to deal with that? (This might rather be nexctloud calendar app issue, though.) EDIT: It is a valid behaviour to save DATE-TIME in UTC (which is indicated by "Z"). Clients seem to deal with that differently:
|
It looks like the Roundcube API changed.
This is tested with Roundcube 1.2.4 (using the complete package, if it has any importance) and todays HEAD of master (aka creating a fresh clone from the repository).
Once I add this to the plugins config.inc.php, it blows:
The error from Roundcubes error log is:
And, more or less the short version, from the apache error log:
Searching through the code base shows that there is no
caldav_driver::insert_default_calendar()
function indeed.The text was updated successfully, but these errors were encountered: