-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider moving the loginURL behind a .well-known #26
Comments
Con: this rules out the enterprise use case of many IDPs on a single site. |
Con: this could be circumvented for widget mode by collecting with "silent" mediation and opening a popup anyway. |
Pro: this more closely matches FedCM's discovery pattern for button mode |
Pro: This provides a more informative UI to the user in the not-yet-logged-in use case |
Important questions: Should we make the navigation gated by consent or constrain the navigation? |
Con: no annotations allowed on the login url, so we would need to add request data parameters and could not remove the |
Con: We couldn't even have pendingRequests! we would need to have the IDP store all potential credentials on login, not knowing the RP. I don't think this works, because we need to provide a token on store. |
@samuelgoto : I think there may be a critical issue here. The IDP needs to know who the RP is when minting a credential under our model. That was made to work (and opened up the timing attack) in FedCM by splitting out the token and accounts endpoints and providing minimal credential and referrer information to them. This model has a single round trip, so I don't think that a RP-blind loginURL works. Thoughts? |
What for? Wasn't it the case that the IdP could |
I was assuming that the credential's |
Isn't the |
I have been treating the IDP page as the Another reason to expose the RP is that this allows the authorization flow to work in the same IDP-controlled window. |
I'm not sure I'm following you ... Indie Auth works fine with a login-url that is RP agnostic in the well known file ... And it could work equally well with a light weight credential store AND and id assertion endpoint. |
Actually reopening as this is now an open question. |
As you mentioned, this is equivalent to window.open from a privacy perspective. But my question is, window.open may eventually get some kind of bounce tracking protection (or maybe already does, in Firefox?). The use here, however, has to bypass any such protection. So opening this popup without user action seems potentially problematic, without some kind of protection? |
Bounce tracking protection is actually easy to prevent from firing here because the popup only needs to get user interaction to prevent it from clearing state. The more general case of navigational tracking protection is the hard problem, however identifying what is and isn't navigational tracking in the first place is a hard problem that there are no general proposals for at this time. |
...so the privacy loss occurs when a credential is returned to the RP, not on navigation.
This has the benefit of showing the credential in the prompt, not a generic IDP information
The text was updated successfully, but these errors were encountered: