Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovering from expired uiHint account info #37

Closed
ekovac opened this issue Aug 27, 2024 · 5 comments
Closed

Recovering from expired uiHint account info #37

ekovac opened this issue Aug 27, 2024 · 5 comments

Comments

@ekovac
Copy link
Contributor

ekovac commented Aug 27, 2024

The explainer as of f6febd5 doesn't include detail about how the user-agent should recover from the state where the account information has expired. With the uiHint expired, if the user has multiple lightweight accounts stored for that IdP with different token values, there wouldn't be a way for the user agent to present the account options to the user in a meaningful way.

Alternatively, does the expiration actually remove the stored credential entirely, thereby requiring the user to go through the Scenario 1 flow?

@bvandersloot-mozilla
Copy link
Collaborator

Good catch! My thought was that the UI would revert to the state as if the ui hint never existed.

That leads to you making a good point that displaying multiple accounts from the same IDP without any kind of UI hint is a challenge for the browser.

Currently Firefox naively shows all options and they look identical. I would probably want to define one to pick and display, leaving the others out of the UI. What are your thoughts on that/how to pick one?

Alternatively, does the expiration actually remove the stored credential entirely, thereby requiring the user to go through the Scenario 1 flow?

No, it should just be the hint that expires.

@bvandersloot-mozilla
Copy link
Collaborator

I'm actually curious what regular FedCM does in the case where there are multiple accounts with no name or picture...

@cbiesinger
Copy link

If required fields are missing we just fail the request, but you can maybe work around that with the magic of unicode, in which case the user would likely be confused...

However, you'd still have the email to disambiguate.

@bvandersloot-mozilla
Copy link
Collaborator

Ah, got it- given name and picture are the only optional ones there. Thanks Christian!

@ekovac
Copy link
Contributor Author

ekovac commented Sep 10, 2024

Closing as duplicate of #40; at the very least the two discussions are closely related and further discussion of this should happen there.

@ekovac ekovac closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants