Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does new ResponseController have to be supported by this package? #26

Open
mitar opened this issue Jul 20, 2023 · 3 comments
Open

Does new ResponseController have to be supported by this package? #26

mitar opened this issue Jul 20, 2023 · 3 comments

Comments

@mitar
Copy link
Contributor

mitar commented Jul 20, 2023

Go 1.20 added ResponseController: golang/go#54136
@mitar
Copy link
Contributor Author

mitar commented Oct 23, 2023 •
edited
Loading

I think we could just add Unwrap to every struct returned by this package. This could allow that any future extension by http package would just continue to work with this package. This package can then eventually generate extension methods as well, but Unwrap is nice to have.

@felixge
Copy link
Owner

felixge commented Oct 24, 2023 •
edited
Loading

I think the new ResponseController should be handled, thanks for bringing this up. PRs welcome!

@dido18
Copy link

dido18 commented Nov 11, 2024

I think this issue has been tackled by this PR #29, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@felixge @mitar @dido18