Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip initializing preview if not configured #806

Closed
bene-starzengruber opened this issue Feb 26, 2021 · 2 comments
Closed

Skip initializing preview if not configured #806

bene-starzengruber opened this issue Feb 26, 2021 · 2 comments

Comments

@bene-starzengruber
Copy link

Is your feature request related to a problem? Please describe.
Currently, the image resource is loaded again for the preview even if no preview is configured.

Describe the solution you'd like
If the preview configuration is falsy, it should early-exit and not load the image.

Describe alternatives you've considered
Not sure if there are any workarounds - it seems like the code-path is unavoidable at the moment.

Additional context
The images we work with are rather big and we do not always need a preview. For these cases it would be nice to save the call.
I can provide a PR if the change is welcomed 😄

@fengyuanchen
Copy link
Owner

If you omit the preview option, then they are not any previewing images.

@fengyuanchen
Copy link
Owner

If you want to know why there are multiple image requests, see #763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants