Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove min_scan_x, min_scan_y and find a better way to get max_scan_x and max_scan_y. #179

Open
nuomi2021 opened this issue Jan 2, 2024 · 2 comments

Comments

@nuomi2021
Copy link
Member

see https://patchwork.ffmpeg.org/project/ffmpeg/patch/TYSPR06MB64337C13ECE97978A56C1152AA62A@TYSPR06MB6433.apcprd06.prod.outlook.com/#81903

@hamzah-mujawar
Copy link

Progress Update:

I have located the file that I need to work on vvc_cabac.c, and found where max_scan and min_scan are defined:
image

I took a look at the definition of FFMAX:
image

@hamzah-mujawar
Copy link

hamzah-mujawar commented Feb 26, 2024

Progress update:

I have added this line of code to help me understand what is going on:
image

This is the resulting output:
image

From my understanding, this returns the max of xc and yc respectively.

I have a question, do we need to find the highest xc and yc value overall, since from what I've seen the higher the xc and yc value that's what max_scan tends to stay on.

Thanking you for your time,
Hamzah Mujawar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants