Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lotus install review and edits #548

Closed
wants to merge 3 commits into from
Closed

Lotus install review and edits #548

wants to merge 3 commits into from

Conversation

ElPaisano
Copy link
Contributor

@ElPaisano ElPaisano commented Apr 17, 2023 •
edited
Loading

@ElPaisano ElPaisano marked this pull request as ready for review April 17, 2023 20:00
@ElPaisano
Copy link
Contributor Author

ElPaisano commented Apr 17, 2023 •
edited
Loading

Questions about Mac steps:

I'm on an Apple Silicon Mac.

  1. Looks like environmental variable still need to be specially set when building and installing from source on an M1. Can someone confirm?

  2. It looks like the brew install steps can be combined with brew install filecoin-project/lotus/lotus? can someone confirm?

  3. Is it make clean all or just make all? Currently it differs between Intel and Apple Silicon.

@ElPaisano ElPaisano linked an issue Apr 18, 2023 that may be closed by this pull request
Review build, compile, and install steps for Lotus. #539
Open
@ElPaisano ElPaisano requested a review from rjan90 April 18, 2023 16:40
@ElPaisano
Copy link
Contributor Author

ElPaisano commented Apr 18, 2023 •
edited
Loading

@rjan90 tagged you and / or @jennijuju in Slack regarding the above questions on this PR, can one of you guys take a look (or point me to someone else)? Thanks

@rjan90
Copy link
Collaborator

rjan90 commented Jun 9, 2024

Closing as outdated.

@rjan90 rjan90 closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjan90 rjan90 Awaiting requested review from rjan90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review build, compile, and install steps for Lotus.
2 participants
@ElPaisano @rjan90