Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url.indexOf returning undefined #13

Open
oliver-moran opened this issue Sep 3, 2014 · 0 comments
Open

url.indexOf returning undefined #13

oliver-moran opened this issue Sep 3, 2014 · 0 comments

Comments

@oliver-moran
Copy link

I don't know enough about the code the understand what was going wrong for me but on line 1152 of firebug-lite.js in version 1.4.0 the variable url was coming in as an Object rather than as a string and so the method url.indexOf was undefined:

this.parseURLParamsArray=function(url){var q=url?url.indexOf("?"):-1;

A patch was to always ensure that url was a string before calling indexOf (i.e. url.toString().indexOf):

this.parseURLParamsArray=function(url){var q=url?url.toString().indexOf("?"):-1;

Sorry for not knowing being able to say why this was happening but I thought it better to report in any case.

And thanks for a great piece of software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant